Remove empty value for boolean attributes in SSR#11708
Merged
aweary merged 1 commit intofacebook:masterfrom Nov 29, 2017
Merged
Remove empty value for boolean attributes in SSR#11708aweary merged 1 commit intofacebook:masterfrom
aweary merged 1 commit intofacebook:masterfrom
Conversation
Collaborator
aweary
pushed a commit
to aweary/react
that referenced
this pull request
Dec 7, 2017
)" This reverts commit e0c3113.
aweary
pushed a commit
to aweary/react
that referenced
this pull request
Dec 7, 2017
)" This reverts commit e0c3113.
aweary
pushed a commit
to aweary/react
that referenced
this pull request
Dec 7, 2017
)" This reverts commit e0c3113.
gaearon
pushed a commit
that referenced
this pull request
Dec 7, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turns out this was super easy @gaearon!
For boolean attributes and overloaded boolean attributes with a value of
truewe can just render the attribute name and save people a few bytes.I'm pretty sure this is safe for all attribute/value pairs that would hit this path.