set className with setAttribute for SVG compat

[jaredly]

Fixes SVG bug where changes to the className prop are not changed in the svg element.

[sophiebits]

If we're going to use the attribute, perhaps we can just mark it MUST_USE_ATTRIBUTE and get rid of the custom mutation method; DOMPropertyOperations.setValueForProperty will call removeAttribute for a null value.

[jaredly]

cool, didn't realize that. Sounds great.

[sophiebits]

Hmm, looks like this will break things in IE actually:

http://stackoverflow.com/questions/2490627/how-can-i-reliably-set-the-class-attr-w-javascript-on-ie-ff-chrome-etc

[jaredly]

:( hmm. Is there a way to just use setattribute for svg elements?
On Feb 13, 2014 7:22 PM, "Ben Alpert" notifications@github.com wrote:

Hmm, looks like this will break things in IE actually:

http://stackoverflow.com/questions/2490627/how-can-i-reliably-set-the-class-attr-w-javascript-on-ie-ff-chrome-etc

Reply to this email directly or view it on GitHubhttps://github.com//pull/1072#issuecomment-35049774
.

[plievone]

Do you know which IE versions would be are affected, perhaps it's less than IE8?
If it would would lead to feature testing IE vs others and DOM vs SVG, then one simple solution might be to use multiple setters at the same time, extra attribute would just be ignored? (Idea from discussion in Dojo bugtracker)

[sophiebits]

My idea was:

if (typeof node.className === "string") {
  node.className = value;
} else {
  node.setAttribute('className', value);
}

[zpao]

Any updates on what we're going to do here?

[forresto]

Firefox gets upset (TypeError: setting a property that has only a getter), and working around this is ugly. Looking forward to taking out those.

[sophiebits]

Closing in favor of #1264.