Don't warn about casing in SSR for non-HTML NS#10452
Merged
sophiebits merged 1 commit intofacebook:masterfrom Aug 13, 2017
Merged
Don't warn about casing in SSR for non-HTML NS#10452sophiebits merged 1 commit intofacebook:masterfrom
sophiebits merged 1 commit intofacebook:masterfrom
Conversation
flarnie
approved these changes
Aug 13, 2017
Contributor
flarnie
left a comment
flarnie
left a comment
There was a problem hiding this comment.
Thanks for doing this! Makes sense to me.
| if (namespaceURI === HTML_NAMESPACE) { | ||
| if (__DEV__) { | ||
| // Should this check be gated by parent namespace? Not sure we want to | ||
| // allow <SVG> or <mATH>. |
Contributor
There was a problem hiding this comment.
nit - probably meant "<MATH>" not "<mATH>"
Collaborator
Author
There was a problem hiding this comment.
This is what I meant. :)
| }).toThrowError(/Cannot assign to read only property.*/); | ||
| }); | ||
|
|
||
| it('warns about lowercase html but not in svg tags', () => { |
Contributor
There was a problem hiding this comment.
awesome - thanks for adding a test!
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10415.