Fix KeyboardAvoidingView not aware of the keyboard closing after it is unmounted#46952
Closed
QichenZhu wants to merge 2 commits intofacebook:mainfrom
Closed
Fix KeyboardAvoidingView not aware of the keyboard closing after it is unmounted#46952QichenZhu wants to merge 2 commits intofacebook:mainfrom
QichenZhu wants to merge 2 commits intofacebook:mainfrom
Conversation
cipolleschi
approved these changes
Oct 10, 2024
Contributor
cipolleschi
left a comment
There was a problem hiding this comment.
Thanks @QichenZhu for fixing this issue!
Contributor
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
6 tasks
Contributor
|
@cipolleschi merged this pull request in 08bd8ac. |
Collaborator
|
This pull request was successfully merged by @QichenZhu in 08bd8ac When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
In the new architecture, if you open the soft keyboard, unmount
KeyboardAvoidingView, close the keyboard, and then remountKeyboardAvoidingView, it still assumes the keyboard is open and displays the keyboard avoiding area.We need to check if the keyboard is still open after remounting.
Fixes #46942
Changelog:
[GENERAL] [FIXED] - Fix KeyboardAvoidingView not aware of the keyboard closing it is unmounted
Test Plan:
Code to reproduce in RNTester:
Steps
Videos
iOS
before.mp4
after.mp4
Android
before-2024-10-11_01.15.28.mp4
after-2024-10-11_01.13.00.mp4