Skip to content

Comments

Fixes LayoutAnimations strict weak ordering sorted check failed#46614

Closed
realsoelynn wants to merge 1 commit intofacebook:mainfrom
realsoelynn:export-D63302091
Closed

Fixes LayoutAnimations strict weak ordering sorted check failed#46614
realsoelynn wants to merge 1 commit intofacebook:mainfrom
realsoelynn:export-D63302091

Conversation

@realsoelynn
Copy link
Contributor

@realsoelynn realsoelynn commented Sep 24, 2024

Summary:
Changelog [Internal]:
Update to make sure Mutation sorting compare function follow strict weak ordering.

Differential Revision: D63302091

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Sep 24, 2024
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Sep 24, 2024

This pull request was exported from Phabricator. Differential Revision: D63302091

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Sep 24, 2024

This pull request was exported from Phabricator. Differential Revision: D63302091

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Sep 24, 2024

This pull request was exported from Phabricator. Differential Revision: D63302091

@realsoelynn @facebook-github-bot
Fixes LayoutAnimations strict weak ordering sorted check failed (face…
08ab073 
…book#46614)

Summary:
Pull Request resolved: facebook#46614

Changelog [Internal]:
Update to make sure Mutation sorting compare function follow strict weak ordering.

Differential Revision: D63302091
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Sep 24, 2024

This pull request was exported from Phabricator. Differential Revision: D63302091

@zhongwuzw
Copy link
Contributor

zhongwuzw commented Sep 25, 2024

@realsoelynn Hi.
I also made a PR #46582. My thoughts is to change shouldFirstComeBeforeSecondRemovesOnly to only sort removed layout mutations. I don't know which one is better, just FYI 🙂 What do you think? 😅

@realsoelynn
Copy link
Contributor Author

realsoelynn commented Sep 25, 2024

@realsoelynn Hi. I also made a PR #46582. My thoughts is to change shouldFirstComeBeforeSecondRemovesOnly to only sort removed layout mutations. I don't know which one is better, just FYI 🙂 What do you think? 😅

Hey hey, we will go with your PR. i will be closing this.

We will continue the conversation on your PR.

@realsoelynn realsoelynn deleted the export-D63302091 branch September 25, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported p: Facebook Partner: Facebook Partner

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@realsoelynn @facebook-github-bot @zhongwuzw