[Text] Ensure that the text background is transparent by default#256
Closed
ide wants to merge 1 commit intofacebook:masterfrom
Closed
[Text] Ensure that the text background is transparent by default#256ide wants to merge 1 commit intofacebook:masterfrom
ide wants to merge 1 commit intofacebook:masterfrom
Conversation
0239b40 to
8b8e691
Compare
eafb8c8 to
a7315fb
Compare
|
@ide While this waits to be merged, how do you set the background to transparent at the moment? |
Collaborator
|
@josebalius - just |
|
@brentvatne For some reason that doesn't seem to work for me :/ It works on almost everything but |
Collaborator
|
@josebalius - strange, can you paste the code here? |
|
Sure Stylesheet: Component's render: styles.create / styles.account are the ones not working, the other two with transparent properties are fine. |
|
@amasad Nvm I had |
For a very simple view I was observing that the text background was black and had to manually be set to transparent. This ensures that text nodes have a transparent background by default.
Test Plan: This example component no longer renders what looks like a black block, and instead displays legible text.
var Example = React.createClass({
render: function() {
return (
<View style={styles.container}>
<Text>hello</Text>
</View>
);
},
});
var styles = StyleSheet.create({
container: {
flex: 1,
},
};
a7315fb to
9b6b1a3
Compare
mganandraj
pushed a commit
to mganandraj/react-native
that referenced
this pull request
Mar 26, 2020
…IScene support from upstream. (facebook#256) * Fix manual merge error. * Fix missing getters from react-native-implementation.macos.js. Cherry pick facebook#28147 into fork to Make RCTKeyWindow multi-window aware and add UIScene support to RCTRedBox. * release _window now to ensure its UIKit ivars are dealloc'd on the main thread as the RCTRedBox can be dealloc'd on a background thread
react-one
pushed a commit
to react-one/react-native
that referenced
this pull request
Sep 24, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For a very simple view I was observing that the text background was black and had to manually be set to transparent. This ensures that text nodes have a transparent background by default.
Test Plan: This example component no longer renders what looks like a black block, and instead displays legible text.