[cleanup] Remove react-clone-referenced-element dependency#23933
Closed
ide wants to merge 1 commit intofacebook:masterfrom
Closed
[cleanup] Remove react-clone-referenced-element dependency#23933ide wants to merge 1 commit intofacebook:masterfrom
ide wants to merge 1 commit intofacebook:masterfrom
Conversation
facebook-github-bot
added
CLA Signed
This package was a dependency for ListView, which is no longer part of RN. Removed the dependency from package.json and yarn.lock. Also removed its pattern from the Jest preset -- ListView is not in this repo and also react-clone-referenced-element was written at a time when Node did not support the same modern JS features as RN. The latest Node 8+ supports the features that react-clone-referenced-element uses so we don't need to transform it. Test plan: - `rg react-clone-referenced-element` - Ensure CI passes
cpojer
approved these changes
Mar 15, 2019
Contributor
cpojer
left a comment
cpojer
left a comment
There was a problem hiding this comment.
Yay, thanks for the cleanup!
facebook-github-bot
approved these changes
Mar 15, 2019
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Collaborator
|
This pull request was successfully merged by @ide in 7d84d0d. When will my fix make it into a release? | Upcoming Releases |
grabbou
pushed a commit
that referenced
this pull request
Apr 8, 2019
Summary: This package was a dependency for ListView, which is no longer part of RN. Removed the dependency from package.json and yarn.lock. Also removed its pattern from the Jest preset -- ListView is not in this repo and also react-clone-referenced-element was written at a time when Node did not support the same modern JS features as RN. The latest Node 8+ supports the features that react-clone-referenced-element uses so we don't need to transform it. [General] [Removed] - Removed unused react-clone-referenced-element dependency Pull Request resolved: #23933 Differential Revision: D14477240 Pulled By: cpojer fbshipit-source-id: 4f6975133b54cc75088262cedd11da20225cada8
grabbou
pushed a commit
that referenced
this pull request
Apr 8, 2019
ListView is still part of 0.59. We cant cherry-pick this one. Solved conflict manually. This reverts commit 27872cf.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This package was a dependency for ListView, which is no longer part of RN. Removed the dependency from package.json and yarn.lock.
Also removed its pattern from the Jest preset -- ListView is not in this repo and also react-clone-referenced-element was written at a time when Node did not support the same modern JS features as RN. The latest Node 8+ supports the features that react-clone-referenced-element uses so we don't need to transform it.
Changelog
[General] [Removed] - Removed unused react-clone-referenced-element dependency
Test Plan
rg react-clone-referenced-element