add basic signature in template#22665
Closed
gengjiawen wants to merge 2 commits intofacebook:masterfrom
Closed
Conversation
facebook-github-bot
added
the
CLA Signed
facebook-github-bot
added
the
Import Started
facebook-github-bot
approved these changes
Dec 17, 2018
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Collaborator
|
@gengjiawen merged commit 63ebbd6 into |
hramos
removed
Import Started
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
react-native-community/cli#38.
add basic signature in template.
Signature file is the same as RNTester.
Test Plan
pass all current ci.
Release Notes
[Android] [Feature] - add basic signature in template