Fix animation bug in 32bit when fromValue is double.#1725
Closed
cxfeng1-zz wants to merge 1 commit intofacebook:masterfrom
Closed
Fix animation bug in 32bit when fromValue is double.#1725cxfeng1-zz wants to merge 1 commit intofacebook:masterfrom
cxfeng1-zz wants to merge 1 commit intofacebook:masterfrom
Conversation
Collaborator
|
This sounds good to me, however AnimationExperimental is deprecated. @vjeux do we want to accept patches for this? |
Contributor
|
@brentvatne doesn't hurt while there's no other solution |
Collaborator
|
Should be an easy review and import for @nicklockwood |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now
RCTAnimationExperimentalManageris not working on 32bit devices.If the fromValue is kind of double value which needs two bytes in 32bit device and the count is 1, the fromFileds array will go wrong.