Skip to content

[website] the react npm package doesn't capitalize the r#142

Merged
vjeux merged 1 commit intomasterfrom
preview
Mar 12, 2015
Merged

[website] the react npm package doesn't capitalize the r#142
vjeux merged 1 commit intomasterfrom
preview

Conversation

@ryanrhee
Copy link
Contributor

Without this npm install fails.
With this, npm install works as expected.

@vjeux
Copy link
Contributor

vjeux commented Mar 12, 2015

It's somehow working for me on npm 1.4.23, but looks like a bug indeed.

vjeux added a commit that referenced this pull request Mar 12, 2015
[website] the react npm package doesn't capitalize the r
@vjeux vjeux merged commit d36b30f into master Mar 12, 2015
@vjeux vjeux deleted the preview branch March 15, 2015 00:39
jfrolich pushed a commit to jfrolich/react-native that referenced this pull request Apr 22, 2020
SudoPlz pushed a commit to SudoPlz/react-native that referenced this pull request Feb 16, 2026
* add feature flkag

* feat(android): pull render architecture

The main change here is that we only call pullTransaction on the UI thread when we are doing a choreographer frame (ready to draw the next frame).

This requires props 2.0 to be enabled, because what might happens is:
- mountingCoordinator version A gets set to execute
- executes A
- mountingCoordinator version B gets set to execute
- we haven't got a new frame yet, while some other thread schedules already the next mount:
- mountingCoordinator version C gets set to execute
- executes C

We skipped executing version B. However, due to the props 2.0 diffing this _shouldn't_ be a problem (remains to be tested)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments