This repository was archived by the owner on Jun 26, 2020. It is now read-only.
Hack around displayName issues in FB products (Simple)#483
Merged
gaearon merged 3 commits intofacebook:masterfrom Feb 2, 2017
Merged
Hack around displayName issues in FB products (Simple)#483gaearon merged 3 commits intofacebook:masterfrom
gaearon merged 3 commits intofacebook:masterfrom
Conversation
gaearon
force-pushed
the
displayname-simple
branch
from
a7a955f to
9c645be
Compare
gaearon
commented
Feb 2, 2017
| if (componentName && moduleName) { | ||
| if ( | ||
| moduleName === componentName || | ||
| moduleName.startsWith(componentName + '.') |
Contributor
Author
There was a problem hiding this comment.
This is ES6 but we use WeakMap already everywhere so I assume it's fine
Contributor
Author
|
#movefast |
pastelsky
pushed a commit
to pastelsky/react-devtools
that referenced
this pull request
Feb 25, 2017
* Hack around displayName issues in FB products * Catch more cases * Remove the base class hack
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same purpose as #482, but much less hacky.
This will work best, but it requires that we also move
ReactComponentandReactPureComponentexports behind an object so that they don't get adisplayNameinternally (facebook/react#8918).