Fork ReactCommon/hermes/inspector as inspector-modern#1112
Open
motiz88 wants to merge 1 commit into
Open
Conversation
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D48897203 |
motiz88
added a commit
to motiz88/hermes
that referenced
this pull request
Sep 1, 2023
Summary: X-link: react/react-native#39253 Changelog: [Internal] Forks `ReactCommon/hermes/inspector` → `ReactCommon/hermes/inspector-modern`. More changes to `inspector-modern` will come in subsequent diffs. The Gradle, CocoaPods and Buck builds of React Native have been updated to use `inspector-modern` everywhere. The code in `ReactCommon/hermes/inspector` is thus **deprecated** and unused in the open source build, and will be deleted in an upcoming diff (likely before the 0.73 cut). NOTE: The reason we're not immediately deleting `ReactCommon/hermes/inspector` is that there are a handful of references to it in Meta's internal monorepo (*outside of React Native*) that we are in the process of migrating away. Once we've deleted the existing `ReactCommon/hermes/inspector`, we *may* rename `inspector-modern` back to `inspector`. Differential Revision: D48897203
motiz88
force-pushed
the
export-D48897203
branch
from
4311b4a to
73116f9
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D48897203 |
motiz88
added a commit
to motiz88/hermes
that referenced
this pull request
Sep 1, 2023
Summary: X-link: react/react-native#39253 Changelog: [Internal] Forks `ReactCommon/hermes/inspector` → `ReactCommon/hermes/inspector-modern`. More changes to `inspector-modern` will come in subsequent diffs. The Gradle, CocoaPods and Buck builds of React Native have been updated to use `inspector-modern` everywhere. The code in `ReactCommon/hermes/inspector` is thus **deprecated** and unused in the open source build, and will be deleted in an upcoming diff (likely before the 0.73 cut). NOTE: The reason we're not immediately deleting `ReactCommon/hermes/inspector` is that there are a handful of references to it in Meta's internal monorepo (*outside of React Native*) that we are in the process of migrating away. Once we've deleted the existing `ReactCommon/hermes/inspector`, we *may* rename `inspector-modern` back to `inspector`. Differential Revision: D48897203
motiz88
force-pushed
the
export-D48897203
branch
from
73116f9 to
67c5ee7
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D48897203 |
motiz88
added a commit
to motiz88/hermes
that referenced
this pull request
Sep 1, 2023
Summary: X-link: react/react-native#39253 Changelog: [Internal] Forks `ReactCommon/hermes/inspector` → `ReactCommon/hermes/inspector-modern`. More changes to `inspector-modern` will come in subsequent diffs. The Gradle, CocoaPods and Buck builds of React Native have been updated to use `inspector-modern` everywhere. The code in `ReactCommon/hermes/inspector` is thus **deprecated** and unused in the open source build, and will be deleted in an upcoming diff (likely before the 0.73 cut). NOTE: The reason we're not immediately deleting `ReactCommon/hermes/inspector` is that there are a handful of references to it in Meta's internal monorepo (*outside of React Native*) that we are in the process of migrating away. Once we've deleted the existing `ReactCommon/hermes/inspector`, we *may* rename `inspector-modern` back to `inspector`. Differential Revision: D48897203
motiz88
force-pushed
the
export-D48897203
branch
from
67c5ee7 to
ee2202c
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D48897203 |
Summary: X-link: react/react-native#39253 Changelog: [Internal] Forks `ReactCommon/hermes/inspector` → `ReactCommon/hermes/inspector-modern`. More changes to `inspector-modern` will come in subsequent diffs. The Gradle, CocoaPods and Buck builds of React Native have been updated to use `inspector-modern` everywhere. The code in `ReactCommon/hermes/inspector` is thus **deprecated** and unused in the open source build, and will be deleted in an upcoming diff (likely before the 0.73 cut). NOTE: The reason we're not immediately deleting `ReactCommon/hermes/inspector` is that there are a handful of references to it in Meta's internal monorepo (*outside of React Native*) that we are in the process of migrating away. Once we've deleted the existing `ReactCommon/hermes/inspector`, we *may* rename `inspector-modern` back to `inspector`. Differential Revision: D48897203
motiz88
force-pushed
the
export-D48897203
branch
from
ee2202c to
e8f4f42
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D48897203 |
motiz88
added a commit
to motiz88/react-native
that referenced
this pull request
Sep 2, 2023
Summary: Pull Request resolved: react#39253 X-link: facebook/hermes#1112 Changelog: [Internal] Forks `ReactCommon/hermes/inspector` → `ReactCommon/hermes/inspector-modern`. More changes to `inspector-modern` will come in subsequent diffs. The Gradle, CocoaPods and Buck builds of React Native have been updated to use `inspector-modern` everywhere. The code in `ReactCommon/hermes/inspector` is thus **deprecated** and unused in the open source build, and will be deleted in an upcoming diff (likely before the 0.73 cut). NOTE: The reason we're not immediately deleting `ReactCommon/hermes/inspector` is that there are a handful of references to it in Meta's internal monorepo (*outside of React Native*) that we are in the process of migrating away. Once we've deleted the existing `ReactCommon/hermes/inspector`, we *may* rename `inspector-modern` back to `inspector`. Differential Revision: D48897203 fbshipit-source-id: dd3c262c9ca0bb88163bfcf5cc51826085fed5e1
facebook-github-bot
pushed a commit
to react/react-native
that referenced
this pull request
Sep 4, 2023
Summary: Pull Request resolved: #39253 X-link: facebook/hermes#1112 Changelog: [Internal] Forks `ReactCommon/hermes/inspector` → `ReactCommon/hermes/inspector-modern`. More changes to `inspector-modern` will come in subsequent diffs. The Gradle, CocoaPods and Buck builds of React Native have been updated to use `inspector-modern` everywhere. The code in `ReactCommon/hermes/inspector` is thus **deprecated** and unused in the open source build, and will be deleted in an upcoming diff (likely before the 0.73 cut). NOTE: The reason we're not immediately deleting `ReactCommon/hermes/inspector` is that there are a handful of references to it in Meta's internal monorepo (*outside of React Native*) that we are in the process of migrating away. Once we've deleted the existing `ReactCommon/hermes/inspector`, we *may* rename `inspector-modern` back to `inspector`. Reviewed By: blakef Differential Revision: D48897203 fbshipit-source-id: 13682747d280a3231b7f6bce560f25ad174304e9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Internal]
Forks
ReactCommon/hermes/inspector→ReactCommon/hermes/inspector-modern. More changes toinspector-modernwill come in subsequent diffs.The Gradle, CocoaPods and Buck builds of React Native have been updated to use
inspector-moderneverywhere. The code inReactCommon/hermes/inspectoris thus deprecated and unused in the open source build, and will be deleted in an upcoming diff (likely before the 0.73 cut).NOTE: The reason we're not immediately deleting
ReactCommon/hermes/inspectoris that there are a handful of references to it in Meta's internal monorepo (outside of React Native) that we are in the process of migrating away. Once we've deleted the existingReactCommon/hermes/inspector, we may renameinspector-modernback toinspector.Differential Revision: D48897203