Fixes #1684 when installing with yarn online

[lpalmes]

This was a quick fix of #1684 which i used to create a new project and the "false" : "0.0.4" dependency was gone.

[lpalmes]

I've tried using a ternary operation here but they all failed, and i didn't want to apply a filter function after concat because i think it obscures the intent.

[Timer]

Oops! I resolved this in master already.
Sorry about this, I didn't see this PR and I started working on the bug immediately when I saw the issue. 😨

I really hope to see contributions from you in the future.

[Timer]

This is out in create-react-app@1.2.1. Please verify it works. 😄

[lpalmes]

That's fine, just wanted to fix this for the sake of the project, i hope i will have some contributions in the future 😄 .
Thanks tim, i'm going to close this then, i guess you can close the issue now that has been fixed 🎉

[lpalmes]

@Timer
Ahhh, much better. Glad this didn't evolve into leftpad 😆

"dependencies": {
    "react": "^15.4.2",
    "react-dom": "^15.4.2"
  },

[Timer]

Thanks for catching it! If you'd like, I'd appreciate an added test case which makes sure we don't install any dependencies other than those 3.

[lpalmes]

Sure, i can take a shot at it, should that be in the file, like check for the correct dependencies and if we found other than react, react-dom, react-scripts just process.exit(1)?

[Timer]

Yeah you can add it to e2e-installs.sh and either call a node script that inspects the package or use a few unix commands. Unix commands would probably be preferred, but Node totally acceptable.

[Timer]

I'm sure you could use awk and accomplish this, or grep depending on the version.

[gaearon]

Thanks for the quick fix. 😅