print a stack if setupProxy.js doesn't parse#10652
print a stack if setupProxy.js doesn't parse#10652scottlamb wants to merge 1 commit intofacebook:mainfrom
Conversation
Before, `npm start` would say this:
```
Unexpected token '?'
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! ui@0.1.0 start: `react-scripts start`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the ui@0.1.0 start script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm ERR! A complete log of this run can be found in:
npm ERR! /home/slamb/.npm/_logs/2021-03-04T20_50_38_776Z-debug.log
```
(The logfile isn't helpful; it doesn't even say the `Unexpected token
'?'` part.)
After, the `Unexpected token '?'` line is replaced with the following:
```
/home/slamb/git/moonfire-nvr/ui/src/setupProxy.js:13
target: process.env.PROXY_TARGET ?? "http://localhost:8080/",
^
SyntaxError: Unexpected token '?'
at wrapSafe (internal/modules/cjs/loader.js:1054:16)
at Module._compile (internal/modules/cjs/loader.js:1102:27)
at Object.Module._extensions..js (internal/modules/cjs/loader.js:1158:10)
at Module.load (internal/modules/cjs/loader.js:986:32)
at Function.Module._load (internal/modules/cjs/loader.js:879:14)
at Module.require (internal/modules/cjs/loader.js:1026:19)
at require (internal/modules/cjs/helpers.js:72:18)
at Object.before (/home/slamb/git/moonfire-nvr/ui/node_modules/react-scripts/config/webpackDevServer.config.js:123:9)
at Server.setupBeforeFeature (/home/slamb/git/moonfire-nvr/ui/node_modules/webpack-dev-server/lib/Server.js:455:18)
at Object.before (/home/slamb/git/moonfire-nvr/ui/node_modules/webpack-dev-server/lib/Server.js:515:16)
```
scottlamb
requested review from
ianschmitz,
iansu,
mrmckeb and
petetnt
as code owners
|
Hi @scottlamb! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
It worked fine on my laptop with node.js v14.15.4, but not on my new workstation with node.js v12.18.2 (as comes with Ubuntu 20.10). It would print "Unexpected token '?'" without any clue what file the error is in. I'm trying to fix that here: facebook/create-react-app#10652
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs. |
2 participants
Before,
npm startwould say this:(The logfile isn't helpful; it doesn't even say the
Unexpected token '?'part.)After, the
Unexpected token '?'line is replaced with the following: