docs: move '/api' from use() to createProxyMiddleware()#10542
docs: move '/api' from use() to createProxyMiddleware()#10542pradishb wants to merge 1 commit intofacebook:masterfrom pradishb:patch-1
Conversation
Path `'/api'` should be the first argument of `createProxyMiddleware()` function, not `use()`.
|
Hi @pradishb! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
pradishb
changed the title
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
suyundukov
left a comment
suyundukov
left a comment
There was a problem hiding this comment.
The '/ api' path must be the first argument to createProxyMiddleware (), not use ().
According to documentation it doesn't work that way. When we pass / api to app.use as the first argument, we are specifying that this middleware should only be used for /api and not for the entire application.
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
2 similar comments
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
3 participants
Path
'/api'should be the first argument ofcreateProxyMiddleware()function, notuse().