fix(all): pass raw value for optional arguments of native bindings#4688
Merged
Merged
Conversation
740272b to
0e32793
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The need for this optimization is coming from TypeScript because in scenario like
some(space)is not able to resolve tostring | numberbecause it is inferred asOption<int32>The optimization is not able to pick up all the external calls. For example, in Fable
interfaceare erased by default and considered external calls by default.But if people want to opt-in for this optimization they can add
[<Erase>]attribute to it.