Merged
Conversation
neenjaw
approved these changes
May 30, 2021
Member
Author
|
Thank you @neenjaw! 😄 |
Member
Author
|
@iHiD / @ErikSchierboom -- on review, flagging this as major. Since this is a reproduction of PR 2429, extra rep should also go to @sachsom95 for both the original exercise, and extra review on the re-write. |
Member
|
(We have no way to automatically retrospectively append these reps, but if you make me a list across all the PRs, I'll manually go through and add them all at ETL time?) |
Member
|
If I get a list of repo/PR number/label, I can do that automatically. |
Member
Author
|
Thanks -- I'll make sure to add this to my "do before launch" list. 😄 |
This was referenced Jul 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reconstructed PR2429, so that the ugly merge commit files were omitted. This PR should be "clean" and only include the additions/edits relating to the
Meltdown Mitigation(conditionals) concept exercise 'cleanup':Renamed exercise to
Meltdown Mitigation. Stub files reman asconditionals.pyandconditionals_test.py.introduction.mdinstructions.mdhints.mdexemplar.pyconditionals_test.pyconditionals.py/.meta/links.jsonfilemeltdown-mitigationto trackconfig.json.meta/config.jsonfilePlease Note: @sachsom95 and @neenjaw gave feedback on the original PR, so should have credit for review here as well.