Skip to content

Comments

Flip assertEqauls() arguments#358

Merged
neenjaw merged 1 commit intoexercism:mainfrom
zembrowski:patch-1
Mar 27, 2021
Merged

Flip assertEqauls() arguments#358
neenjaw merged 1 commit intoexercism:mainfrom
zembrowski:patch-1

Conversation

@zembrowski
Copy link
Contributor

@neenjaw
Copy link
Collaborator

neenjaw commented Mar 26, 2021

Thanks for opening a PR to help improve the PHP track!

I'll need to check more closely, but I think this work is already being done in an open PR in #357 by @codedge which was opened 2 days ago.

If it isn't overlapping I'll take a look at this tonight to review it.

@neenjaw
Copy link
Collaborator

neenjaw commented Mar 27, 2021

Awesome! I think @codedge missed part of this meetup test file, which your PR covers! Most appreciated!!

@neenjaw neenjaw merged commit 04c4db1 into exercism:main Mar 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants