[V3] Poetry Club Door Policy: fix everything around this exercise#1043
Merged
SleeplessByte merged 16 commits intomainfrom Apr 2, 2021
Merged
[V3] Poetry Club Door Policy: fix everything around this exercise#1043SleeplessByte merged 16 commits intomainfrom
SleeplessByte merged 16 commits intomainfrom
Conversation
SleeplessByte
added
chore 🔧
10 tasks
kotp
reviewed
Mar 16, 2021
| - There are two methods to take a part of a string (for example, everything | ||
| except the first character). | ||
| - Capitalization means having a single Uppercase character, followed by lowercase characters. | ||
| - There are two methods to take a part of a string (for example, everything except the first character). |
Member
There was a problem hiding this comment.
This has me on the edge of my seat, feeling like the two method names might be coming up… but then, like the ending of Monty Python and the Holy Grail, kind of leaves you wondering what happened.
Perhaps "to take a part of a string" can be stated "to take a portion of a string" as "apart" and "a part" has simlar meanings, and I believe a portion rather than dissassemble is meant here. No need to change (of course) if that is only my take on that wording though.
ErikSchierboom
approved these changes
Mar 16, 2021
SleeplessByte
commented
Apr 2, 2021
Co-authored-by: Victor Goff <keeperotphones@gmail.com>
SleeplessByte
force-pushed
the
chore/rename-strings
branch
from
e255f51 to
6530848
Compare
Member
Author
|
/sync |
Member
Author
|
/format |
Contributor
|
The "Format code" action has started running. |
Contributor
|
The "Format code" action has finished running. |
ErikSchierboom
added
x:size/large
This was referenced Jul 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reviewers, please spell/grammar check
Related #1017
Changes
strings) to story based exercisepolicy-club-door-policyconfig.jsonstringstoconfig.json