Send correct HTTP/1.1 headers#10
Merged
tmm1 merged 1 commit intoeventmachine:masterfrom Dec 21, 2011
groupme:master
Merged
Conversation
Contributor
Author
|
Bump :) |
Contributor
|
+1 on this, please. |
|
+1 |
|
+1 - we're trying to use Pingdom for external monitoring and they won't monitor this service because it responds with '200 ...' instead of '200 OK'. |
|
+1 |
Contributor
|
This is going to break other pull requests because of the spacing changes, but I'm merging it. |
|
Thanks for getting this in! Feels better to use it than before. :-) |
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was trying to use this server with pingdom and it rejected the header response with the ellipsis in it.
I added support for proper HTTP/1.1 headers.
I also capitalized the header names to conform to more standard header practice.
Other than this header fun, this server is awesome. Thanks!