feat(gap-detection): detect and process missing blocks in addition to incomplete blocks #77
+559
−99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… incomplete blocks Previously gap detection only found incomplete blocks (rows where complete=0), missing truly missing blocks (rows that were never inserted). This change: - Add GetMissingBlocksInRange() to state manager using ClickHouse numbers() - Update GapStateProvider interface and GetGaps() to return GapResult with both Incomplete and Missing block lists plus scan duration - Make processBlock public (ProcessBlock) in all processors for gap filling - Add ProcessBlock to BlockProcessor interface - Add Prometheus metrics: GapsDetected, GapsReprocessed, GapScanDuration, GapsFound - Update checkGaps() to handle both types: ReprocessBlock for incomplete, ProcessBlock for missing blocks - Add comprehensive tests for both gap types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously gap detection only found incomplete blocks (rows where complete=0), missing truly missing blocks (rows that were never inserted). This change: