Support up to 32 function params and limit math specialization to 8 params#188
Merged
Conversation
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #188 +/- ##
==========================================
- Coverage 97.88% 97.67% -0.22%
==========================================
Files 64 64
Lines 12550 12599 +49
==========================================
+ Hits 12285 12306 +21
- Misses 265 293 +28 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…r, and add mixed parameters test case
…st mixed parameter test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR increases the maximum function input parameter count limit to 32, but limits the mathematical specialized parameters count to a maximum of 8. If a function contains more than 8 math parameters, it will skip specialization and treat all parameters as dynamic fallback.