refactor!: remove enum prefix from bindings#65
Open
scootermon wants to merge 6 commits intoesp-rs:mainfrom
Open
refactor!: remove enum prefix from bindings#65scootermon wants to merge 6 commits intoesp-rs:mainfrom
scootermon wants to merge 6 commits intoesp-rs:mainfrom
Conversation
OpenThread already uses the convention of prefixing enum variants with the enum name. Adding the enum type name as a prefix is redundant and only makes the generated Rust code more verbose.
scootermon
force-pushed
the
refactor/drop-enum-prefix
branch
from
b1f1a9b to
d61bd96
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a collection of small-ish changes.