feat(explorer): support explorer.position = "right"#431
Open
YaakovEidelman wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
explorer.position = "right", placing the file explorer on the right of thediff view (
[ original | modified | explorer ]).Closes #430
Changes
ui/layout.lua:arrange()now pins width forleft/rightand height forbottom(wasleftvs. else).config.lua+README.md: document the new"right"value.tests/ui/layout_spec.lua: adds "Case 2b" verifying the right panel gets its configured width and diff panes stay equal.Testing
layout_spec.luapasses including the new case.Splitalready supportedright; this teaches the layout manager to size it as a vertical panel.