Fix deprecation warning and failing test under Node v6 (fixes #70)#71
Closed
mcous wants to merge 1 commit intoericelliott:masterfrom
mcous:fix-for-node-v6
Closed
Fix deprecation warning and failing test under Node v6 (fixes #70)#71mcous wants to merge 1 commit intoericelliott:masterfrom mcous:fix-for-node-v6
mcous wants to merge 1 commit intoericelliott:masterfrom
mcous:fix-for-node-v6
Conversation
Fixes two problems with credential under Node v6: * crypto.pbkdf2 without an explicit digest algorithm has been deprecated * The formatting of logging Error objects was changed by nodejs/node#4582 So: * Node v6 is now tested by Travis * "SHA1" (the old default) is now present as an explicit parameter * A CLI test that was checking stderr with equality (and failing) now uses a regex
Author
|
Travis gave me failures with the timing tests under Node v4 and v5, but I'm unable to reproduce them locally. It also gave me a failure with v0.10, which (as I have just now discovered) does not have a digest parameter at all. Seeing as v0.10 is going to be supported by Node for another 6 months, I'm not sure about the best course of action here. |
Owner
|
Unless you can think of something better, I think this may simply have to be a breaking change. |
Author
|
I could check the Node version and apply the arguments accordingly, which would be ugly but work. |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes two problems with credential under Node v6:
So: