Skip to content

ci: fix some issues post #837. - #851

Merged
mattklein123 merged 4 commits into
envoyproxy:masterfrom
htuch:ci-fixes
Apr 27, 2017
Merged

ci: fix some issues post #837.#851
mattklein123 merged 4 commits into
envoyproxy:masterfrom
htuch:ci-fixes

Conversation

@htuch

@htuch htuch commented Apr 27, 2017

Copy link
Copy Markdown
Member

Alpine build was failing, fixed and changed to build even when not pushing to master to catch this
next time.

Alpine build was failing, fixed and changed to build even when not pushing to master to catch this
next time.
@junr03

junr03 commented Apr 27, 2017

Copy link
Copy Markdown
Member

@htuch the docker login -e flag has been deprecated. Given you have not merged yet do you mind deleting?

@htuch

htuch commented Apr 27, 2017

Copy link
Copy Markdown
Member Author

@junr03 Done, can you verify this is what you want? I can't test this locally, so it will break on master merge if it's wrong. Thanks.

@junr03 junr03 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, perfect. Thanks!

@mattklein123
mattklein123 merged commit bf899f1 into envoyproxy:master Apr 27, 2017
mathetake pushed a commit that referenced this pull request Mar 3, 2026
**Description**

Replacing `latest` suffix for helm charts and docker image. Replacing
suffix with commit message.

**Related Issues/PRs (if applicable)**

#851

---------

Signed-off-by: Aaron Choo <achoo30@bloomberg.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants