Skip to content

Add proxy-wasm-cpp-host PR#553 endianness fix for s390x - #46261

Merged
yanavlasov merged 1 commit into
envoyproxy:release/v1.38from
surenderky:s390x-backport-553
Jul 20, 2026
Merged

Add proxy-wasm-cpp-host PR#553 endianness fix for s390x#46261
yanavlasov merged 1 commit into
envoyproxy:release/v1.38from
surenderky:s390x-backport-553

Conversation

@surenderky

Copy link
Copy Markdown
Contributor

This PR backports the proxy-wasm-cpp-host PR proxy-wasm/proxy-wasm-cpp-host#553 portion of the changes from Envoy PR #45756 to the Envoy 1.38 branch.

On s390x writing the native host representation into Wasm memory results in incorrect byte ordering. Converting the value using htowasm() before calling setMemory() ensures the value is stored in the correct byte order expected by the Wasm runtime. This change affects only the proxy-wasm-cpp-host dependency.

The original PR contains additional updates related to Wasmtime version changes. Those changes are intentionally not included here, since they are not required for Envoy 1.38. This PR only carries the proxy-wasm-cpp-host fix needed for s390x. The patch is verified successfully on s390x machine.

Signed-off-by: Surender Yadav <surender.yadav1@ibm.com>
@repokitteh-read-only repokitteh-read-only Bot added the deps Approval required for changes to Envoy's external dependencies label Jul 20, 2026
@repokitteh-read-only

Copy link
Copy Markdown

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).
envoyproxy/dependency-shepherds assignee is @agrawroh

🐱

Caused by: #46261 was opened by surenderky.

see: more, trace.

@surenderky

Copy link
Copy Markdown
Contributor Author

CC @jwendell

@repokitteh-read-only repokitteh-read-only Bot removed the deps Approval required for changes to Envoy's external dependencies label Jul 20, 2026
@yanavlasov
yanavlasov merged commit 4e9f5e4 into envoyproxy:release/v1.38 Jul 20, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants