Add proxy-wasm-cpp-host PR#553 endianness fix for s390x - #46261
Merged
yanavlasov merged 1 commit intoJul 20, 2026
Conversation
Signed-off-by: Surender Yadav <surender.yadav1@ibm.com>
|
CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to |
Contributor
Author
|
CC @jwendell |
jwendell
approved these changes
Jul 20, 2026
yanavlasov
approved these changes
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR backports the proxy-wasm-cpp-host PR proxy-wasm/proxy-wasm-cpp-host#553 portion of the changes from Envoy PR #45756 to the Envoy 1.38 branch.
On s390x writing the native host representation into Wasm memory results in incorrect byte ordering. Converting the value using htowasm() before calling setMemory() ensures the value is stored in the correct byte order expected by the Wasm runtime. This change affects only the proxy-wasm-cpp-host dependency.
The original PR contains additional updates related to Wasmtime version changes. Those changes are intentionally not included here, since they are not required for Envoy 1.38. This PR only carries the proxy-wasm-cpp-host fix needed for s390x. The patch is verified successfully on s390x machine.