//test/common/http:async_client_impl_test is flaky

[htuch]

 bazel test //test/common/http:async_client_impl_test --runs_per_test=5000

I see a few fails per thousand with the following failed test case:

[ RUN      ] AsyncClientImplTest.MultipleStreams
unknown file: Failure

Unexpected mock function call - returning directly.
    Function call: onHeaders_(@0x1d426e0 {':status','200'}{'x-envoy-upstream-service-time','4'}, false)
Google Mock tried the following 1 expectation, but it didn't match:

test/common/http/async_client_impl_test.cc:238: EXPECT_CALL(stream_callbacks_, onHeaders_(HeaderMapEqualRef(&expected_headers), false))...
  Expected arg #0: header map equal ref 0x7ffeb50b8580
           Actual: {':status','200'}{'x-envoy-upstream-service-time','4'}
         Expected: to be called once
           Actual: never called - unsatisfied and active
test/common/http/async_client_impl_test.cc:238: Failure
Actual function call count doesn't match EXPECT_CALL(stream_callbacks_, onHeaders_(HeaderMapEqualRef(&expected_headers), false))...
         Expected: to be called once
           Actual: never called - unsatisfied and active

[lizan]

Hmm, this is probably my fault, the test shouldn't expect x-envoy-upstream-service-time with exact value. Will try a fix.

[htuch]

It's blocking #837, for whatever reason I seem to hit it reliably in Travis on my ASAN runs (it happens with both ASAN and without). @lizan do you have a quick fix PR or want to disable?

[lizan]

@htuch I should be able to get a fix PR by end of today, feel free to disable if that doesn't work for you.

[mattklein123]

I will fix @lizan don't worry about it. I don't think this is your fault but I can't remember.

[lizan]

Thanks @mattklein123, I just remember I wrote those tests.

[mattklein123]

I think you copied them from tests I wrote :) The flake exists elsewhere also.