Skip to content

more hermetic separation for gemini auth config files in E2E#915

Merged
gtrrz-victor merged 3 commits intomainfrom
soph/more-gemini-fixes
Apr 11, 2026
Merged

more hermetic separation for gemini auth config files in E2E#915
gtrrz-victor merged 3 commits intomainfrom
soph/more-gemini-fixes

Conversation

@Soph
Copy link
Copy Markdown
Collaborator

@Soph Soph commented Apr 10, 2026

Entire-Checkpoint: 58a364f11b5f


Note

Low Risk
Low risk and test-only, but it changes how gemini is bootstrapped and which HOME/acknowledgment files it reads, so Gemini E2E runs could fail if the CLI expects additional state in the real home directory.

Overview
Makes Gemini E2E runs hermetic by isolating Gemini CLI state into a per-repo test HOME directory. The Gemini agent no longer writes global auth config in Bootstrap; instead, SetupRepo creates a dedicated ...-gemini-home directory, seeds .gemini/settings.json, and writes acknowledgment state there.

Gemini prompt and interactive session execution now explicitly set HOME to this test directory (and preserve TERM for tmux runs), removing previous reliance on the developer’s real home directory and eliminating the prior global mutex/serialization around acknowledgments. Adds a standalone docs/gmeta-poc-plan.md planning document (no production code changes).

Reviewed by Cursor Bugbot for commit f7f3d0d. Configure here.

Copilot AI review requested due to automatic review settings April 10, 2026 12:46
@Soph Soph requested a review from a team as a code owner April 10, 2026 12:46
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to make Gemini E2E runs more hermetic by moving Gemini auth/settings/acknowledgment files out of the real user home directory and into a per-test isolated HOME, reducing cross-test and developer-environment interference.

Changes:

  • Create and populate a per-repo “Gemini test HOME” directory (settings + acknowledgments) during E2E repo setup.
  • Stop writing Gemini settings into the real ~/.gemini during agent bootstrap and instead run Gemini with HOME pointed at the test-specific directory.
  • Add a new docs/gmeta-poc-plan.md document (appears unrelated to the PR title/purpose).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
e2e/testutil/repo.go Creates an isolated Gemini HOME dir per test repo and writes Gemini settings/acknowledgments there.
e2e/agents/gemini.go Stops global bootstrap config writes; sets HOME for Gemini subprocesses and tmux sessions to the isolated directory.
docs/gmeta-poc-plan.md Adds a gmeta POC plan document (scope seems separate from Gemini E2E hermeticity).

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@gtrrz-victor gtrrz-victor enabled auto-merge April 11, 2026 12:28
@gtrrz-victor gtrrz-victor merged commit ab92924 into main Apr 11, 2026
9 checks passed
@gtrrz-victor gtrrz-victor deleted the soph/more-gemini-fixes branch April 11, 2026 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants