Merged
Conversation
Entire-Checkpoint: 3dc538934858
Entire-Checkpoint: 5401d770e313
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the E2E harness to better tolerate upstream TUI/UX changes in Cursor and Gemini CLIs, reducing startup-related flakes in CI while keeping the core product code unchanged.
Changes:
- Pre-acknowledge the repo-managed Gemini
entire-searchagent during E2E repo setup by writing a hash entry into Gemini’s acknowledgments file. - Expand Gemini interactive startup dialog detection to include new “agent discovered” prompts.
- Broaden Cursor CLI prompt readiness detection to match both legacy and current placeholder text.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| e2e/testutil/repo.go | Adds Gemini acknowledgments seeding during repo setup to avoid discovery prompts blocking startup. |
| e2e/agents/gemini.go | Expands startup prompt regex to recognize new Gemini dialogs. |
| e2e/agents/cursor_cli.go | Updates prompt regex to handle multiple Cursor CLI placeholder variants. |
pjbgf
approved these changes
Apr 10, 2026
Collaborator
Author
|
Addressing the comments in a follow up PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this is a slimmed down version of #908
It only keeps the E2E harness related fixes, the other fix regarding condension we should handle separate later
Note
Medium Risk
Moderate risk because it changes E2E session synchronization and writes a Gemini acknowledgments file in the user home directory, which could affect parallel runs or local environments if the format/paths differ.
Overview
Improves E2E reliability for Cursor and Gemini CLI agents by broadening prompt/startup dialog detection to handle newer UI copy and additional onboarding modals.
For Gemini E2E repos,
SetupReponow proactively records an acknowledgment for the generatedentire-searchagent by hashing the agent file and updating~/.gemini/acknowledgments/agents.jsonunder a mutex to avoid interactive “acknowledge and enable” blocks during tests.Reviewed by Cursor Bugbot for commit 7aecd3f. Configure here.