don't show multiple spaces for codex single line start message rendering#857
Merged
don't show multiple spaces for codex single line start message rendering#857
Conversation
Entire-Checkpoint: 573a97ec8d2c
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the session-start hook banner formatting to avoid Codex rendering "\n " indentation as multiple spaces when displayed as a single line, while keeping the existing multi-line banner style for other agents.
Changes:
- Introduces
sessionStartMessage(agentName, emptyRepo)to centralize banner formatting and special-case Codex as a single-line message. - Updates
handleLifecycleSessionStartto use the new helper for both normal and empty-repo banners. - Adds tests to assert Codex uses a single-line banner and non-Codex agents keep the multi-line banner.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
cmd/entire/cli/lifecycle.go |
Refactors session-start banner construction; adds Codex single-line formatting helper. |
cmd/entire/cli/lifecycle_test.go |
Adds assertions for multi-line default banner and new unit tests for Codex single-line banner output. |
Entire-Checkpoint: 3790cba265e6
pjbgf
previously approved these changes
Apr 5, 2026
gtrrz-victor
approved these changes
Apr 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before:
After:
Note
Low Risk
Low risk: changes only the SessionStart hook message formatting and adds unit tests; no auth, data, or strategy logic is modified.
Overview
Adjusts the SessionStart hook banner to be agent-specific: Codex now receives a single-line
Powered by Entire:message (including the empty-repo warning) to avoid awkward spacing/rendering, while other agents keep the existing multi-line banner.Introduces a small
sessionStartMessagehelper and expands lifecycle tests to assert the Codex vs default formatting behavior.Reviewed by Cursor Bugbot for commit 8df056f. Configure here.