Skip to content

don't show multiple spaces for codex single line start message rendering#857

Merged
Soph merged 2 commits intomainfrom
soph/codex-warning-fix
Apr 7, 2026
Merged

don't show multiple spaces for codex single line start message rendering#857
Soph merged 2 commits intomainfrom
soph/codex-warning-fix

Conversation

@Soph
Copy link
Copy Markdown
Collaborator

@Soph Soph commented Apr 5, 2026

Before:

SessionStart hook (completed)
  warning: Powered by Entire:  This conversation will be linked to your next commit.

After:

SessionStart hook (completed)
  warning: Powered by Entire: This conversation will be linked to your next commit.

Note

Low Risk
Low risk: changes only the SessionStart hook message formatting and adds unit tests; no auth, data, or strategy logic is modified.

Overview
Adjusts the SessionStart hook banner to be agent-specific: Codex now receives a single-line Powered by Entire: message (including the empty-repo warning) to avoid awkward spacing/rendering, while other agents keep the existing multi-line banner.

Introduces a small sessionStartMessage helper and expands lifecycle tests to assert the Codex vs default formatting behavior.

Reviewed by Cursor Bugbot for commit 8df056f. Configure here.

@Soph Soph requested a review from a team as a code owner April 5, 2026 15:29
Copilot AI review requested due to automatic review settings April 5, 2026 15:29
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the session-start hook banner formatting to avoid Codex rendering "\n " indentation as multiple spaces when displayed as a single line, while keeping the existing multi-line banner style for other agents.

Changes:

  • Introduces sessionStartMessage(agentName, emptyRepo) to centralize banner formatting and special-case Codex as a single-line message.
  • Updates handleLifecycleSessionStart to use the new helper for both normal and empty-repo banners.
  • Adds tests to assert Codex uses a single-line banner and non-Codex agents keep the multi-line banner.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
cmd/entire/cli/lifecycle.go Refactors session-start banner construction; adds Codex single-line formatting helper.
cmd/entire/cli/lifecycle_test.go Adds assertions for multi-line default banner and new unit tests for Codex single-line banner output.

Entire-Checkpoint: 3790cba265e6
pjbgf
pjbgf previously approved these changes Apr 5, 2026
@Soph Soph merged commit 9a070c1 into main Apr 7, 2026
3 checks passed
@Soph Soph deleted the soph/codex-warning-fix branch April 7, 2026 15:12
@Soph Soph restored the soph/codex-warning-fix branch April 8, 2026 14:44
Soph added a commit that referenced this pull request Apr 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants