Skip to content

Copilot E2E Fixes#797

Merged
Soph merged 4 commits intomainfrom
soph/copilot-e2e-fixes-again
Mar 30, 2026
Merged

Copilot E2E Fixes#797
Soph merged 4 commits intomainfrom
soph/copilot-e2e-fixes-again

Conversation

@Soph
Copy link
Copy Markdown
Collaborator

@Soph Soph commented Mar 28, 2026

three things:

  • make copilot e2e work locally if normal auth is available
  • add dismiss handling if copilot ends up in a slash command mode and
  • skip one subagent test for copilot because copilot is not properly waiting for the subagent to finish

Note

Low Risk
Low risk: changes are confined to E2E harness behavior (tmux input handling, env forwarding, and one test skip) and do not affect production logic, but may alter Copilot CLI test interactions and retry semantics.

Overview
Improves copilot-cli E2E stability by pre-clearing the input line before sending prompts, adding helpers to dismiss slash-command autocomplete, and retrying once when Copilot leaves an Unknown command: / state after submission.

Updates interactive session startup to optionally forward additional auth/config environment (XDG_CONFIG_HOME, GH_CONFIG_DIR) instead of hard-requiring COPILOT_GITHUB_TOKEN, enabling local runs that rely on existing gh/Copilot login state. Also skips TestSingleSessionSubagentCommitInTurn for copilot-cli due to non-deterministic background subagent completion ordering.

Written by Cursor Bugbot for commit 30d7798. Configure here.

Soph added 3 commits March 28, 2026 14:44
Entire-Checkpoint: 0f0f0ce6d09e
Entire-Checkpoint: 16574dc8da32
Entire-Checkpoint: b53d00df1f4f
@Soph Soph requested a review from a team as a code owner March 28, 2026 20:44
Copilot AI review requested due to automatic review settings March 28, 2026 20:45
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Improves the Copilot CLI E2E harness reliability and local usability by relaxing auth assumptions, adding input cleanup/retry handling for Copilot’s interactive UI quirks, and skipping an unstable Copilot-specific subagent commit test.

Changes:

  • Skip the “subagent commit in turn” E2E test for copilot-cli due to Copilot background-subagent timing/hook ordering.
  • Harden copilot-cli interactive sending by clearing the input line up front, dismissing autocomplete, and retrying when Copilot gets into a slash-command error state.
  • Forward additional auth/config-related environment variables into the tmux session to support local auth (not just token auth).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
e2e/tests/single_session_test.go Skips an unstable Copilot-only subagent/commit assertion.
e2e/agents/copilot-cli.go Makes Copilot interactive tmux session more robust (env forwarding + input cleanup + retry logic).

Entire-Checkpoint: 19150b296396
@Soph Soph merged commit f0749a7 into main Mar 30, 2026
12 of 13 checks passed
@Soph Soph deleted the soph/copilot-e2e-fixes-again branch March 30, 2026 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants