Conversation
Entire-Checkpoint: 832b6659f697
Entire-Checkpoint: 8521d1323a05
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends the E2E harness to cover “external agent” integrations (via the external agent protocol) by adding a deterministic test agent (roger-roger) and associated E2E scenarios, and wiring it into CI.
Changes:
- Add a
roger-rogerexternal agent implementation and a mise task to run its E2E suite locally. - Update E2E repo setup to pre-enable
external_agentsin settings when running against an external agent. - Add new E2E test cases and update CI workflows to include a
roger-rogermatrix entry.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
mise-tasks/test/e2e/roger-roger |
New local task to build roger-roger binaries and run E2E tests with artifacts. |
e2e/testutil/repo.go |
Pre-writes .entire/settings.json enabling external_agents for external-agent runs before entire enable. |
e2e/tests/external_agent_test.go |
New E2E tests intended to validate external-agent flows and checkpoint metadata. |
e2e/agents/roger_roger.go |
Registers and runs the roger-roger external agent if binaries are present on PATH. |
e2e/agents/agent.go |
Adds an ExternalAgent optional interface for agent-type detection in the harness. |
.github/workflows/e2e.yml |
Adds roger-roger to the E2E matrix, installs its binaries, and filters tests for that job. |
.github/workflows/e2e-isolated.yml |
Adds roger-roger as an isolated workflow option and installs its binaries. |
nodo
force-pushed
the
nodo/e2e-external-agents
branch
from
9be897b to
c743873
Compare
nodo
force-pushed
the
nodo/e2e-external-agents
branch
from
c743873 to
f5d87c1
Compare
Soph
previously approved these changes
Mar 16, 2026
Collaborator
Soph
left a comment
Soph
left a comment
There was a problem hiding this comment.
Should we also add it to e2e:canary ? I feel it's also fine to run this always... but I guess the issue is that we would need to make sure it's installed on every users machine? But I think we could "abuse" mise for that 🤔 But fine handling that in another PR
Entire-Checkpoint: 8e54afefb3cc
Soph
approved these changes
Mar 16, 2026
Contributor
Author
I am going back and forth with this, let's discuss separately. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add some simple tests to our e2e suite using our test external agent https://github.com/entireio/roger-roger