Conversation
PR SummaryLow Risk Overview Refactors many tests to use Written by Cursor Bugbot for commit d9c136f. Configure here. |
Entire-Checkpoint: a547a0c962e4
Entire-Checkpoint: 58dc5a0625f3
There was a problem hiding this comment.
Pull request overview
Updates the repository toolchain configuration to Go 1.26.1 and golangci-lint 2.11.3, and applies small code/test adjustments to satisfy (or explicitly silence) new lint findings.
Changes:
- Bump Go version to 1.26.1 in
mise.tomlandgo.mod. - Bump
golangci-lintto 2.11.3 inmise.toml. - Replace manual nil-guards in tests with
testify/require.NotNil, and add targeted//nolint:gosecsuppressions for flaggedos.WriteFilecall sites.
Reviewed changes
Copilot reviewed 27 out of 27 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| perf/span_test.go | Switch nil span assertion to require.NotNil. |
| mise.toml | Bump Go and golangci-lint tool versions. |
| go.mod | Align go directive with updated toolchain version. |
| cmd/entire/cli/utils.go | Add gosec suppression on os.WriteFile in helper copy routine. |
| cmd/entire/cli/trail/store_test.go | Use require.NotNil for result validation. |
| cmd/entire/cli/summarize/summarize_test.go | Use require.NotNil for summary validation. |
| cmd/entire/cli/strategy/session_state_test.go | Replace nil checks with require.NotNil in multiple tests. |
| cmd/entire/cli/strategy/rewind_test.go | Use require.NotNil for preview validation. |
| cmd/entire/cli/strategy/manual_commit_test.go | Use require.NotNil for loaded state validation. |
| cmd/entire/cli/strategy/manual_commit_hooks.go | Add gosec suppressions for writing commit message file passed by hook. |
| cmd/entire/cli/strategy/manual_commit_condensation_test.go | Use require.NotNil for token usage results. |
| cmd/entire/cli/strategy/manual_commit_attribution_test.go | Use require.NotNil for attribution result validation. |
| cmd/entire/cli/state_test.go | Use require.NotNil for loaded state validation. |
| cmd/entire/cli/lifecycle_test.go | Use require.NotNil for loaded state validation after compaction. |
| cmd/entire/cli/lifecycle.go | Add gosec suppression for writing prompt.txt under session metadata dir. |
| cmd/entire/cli/hook_registry_test.go | Use require.NotNil for subcommand lookup. |
| cmd/entire/cli/git_operations_test.go | Use require.NotNil for author result validation. |
| cmd/entire/cli/explain_test.go | Use require.NotNil for flag lookup. |
| cmd/entire/cli/checkpoint/checkpoint_test.go | Use require.NotNil for committed summary validation. |
| cmd/entire/cli/agent/opencode/transcript_test.go | Use require.NotNil for parsed session/usage validation. |
| cmd/entire/cli/agent/opencode/lifecycle_test.go | Use require.NotNil for parsed event validation. |
| cmd/entire/cli/agent/geminicli/lifecycle_test.go | Use require.NotNil for parsed event validation. |
| cmd/entire/cli/agent/factoryaidroid/lifecycle_test.go | Use require.NotNil for parsed event validation. |
| cmd/entire/cli/agent/cursor/lifecycle_test.go | Use require.NotNil for parsed event validation. |
| cmd/entire/cli/agent/copilotcli/lifecycle_test.go | Use require.NotNil for parsed event validation. |
| cmd/entire/cli/agent/copilotcli/hooks_test.go | Use require.NotNil for round-trip lookup validation. |
| cmd/entire/cli/agent/claudecode/lifecycle_test.go | Use require.NotNil for parsed event/result validation. |
You can also share your feedback on Copilot code review. Take the survey.
Entire-Checkpoint: 2a7777ef04d0
Bump to go 1.26.1 and golangci-lint 2.11.3 and fixing / silencing some of the new things.