Skip to content

go 1.26.1 and golangci-lint 2.11.3#699

Merged
Soph merged 4 commits intomainfrom
soph/go-1-26-1
Mar 16, 2026
Merged

go 1.26.1 and golangci-lint 2.11.3#699
Soph merged 4 commits intomainfrom
soph/go-1-26-1

Conversation

@Soph
Copy link
Copy Markdown
Collaborator

@Soph Soph commented Mar 16, 2026

Bump to go 1.26.1 and golangci-lint 2.11.3 and fixing / silencing some of the new things.

Copilot AI review requested due to automatic review settings March 16, 2026 10:22
@cursor
Copy link
Copy Markdown

cursor bot commented Mar 16, 2026

PR Summary

Low Risk
Low risk: primarily a toolchain/linter bump plus test assertion refactors and additional gosec suppressions on existing internal file writes.

Overview
Updates the toolchain to Go 1.26.1 (via go.mod/mise.toml) and golangci-lint 2.11.3.

Refactors many tests to use testify/require for non-nil assertions, and adds targeted //nolint:gosec annotations on existing os.WriteFile calls (e.g., lifecycle.go, manual_commit_hooks.go, utils.go) to silence new gosec findings about file paths.

Written by Cursor Bugbot for commit d9c136f. Configure here.

Soph added 2 commits March 16, 2026 11:25
Entire-Checkpoint: a547a0c962e4
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the repository toolchain configuration to Go 1.26.1 and golangci-lint 2.11.3, and applies small code/test adjustments to satisfy (or explicitly silence) new lint findings.

Changes:

  • Bump Go version to 1.26.1 in mise.toml and go.mod.
  • Bump golangci-lint to 2.11.3 in mise.toml.
  • Replace manual nil-guards in tests with testify/require.NotNil, and add targeted //nolint:gosec suppressions for flagged os.WriteFile call sites.

Reviewed changes

Copilot reviewed 27 out of 27 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
perf/span_test.go Switch nil span assertion to require.NotNil.
mise.toml Bump Go and golangci-lint tool versions.
go.mod Align go directive with updated toolchain version.
cmd/entire/cli/utils.go Add gosec suppression on os.WriteFile in helper copy routine.
cmd/entire/cli/trail/store_test.go Use require.NotNil for result validation.
cmd/entire/cli/summarize/summarize_test.go Use require.NotNil for summary validation.
cmd/entire/cli/strategy/session_state_test.go Replace nil checks with require.NotNil in multiple tests.
cmd/entire/cli/strategy/rewind_test.go Use require.NotNil for preview validation.
cmd/entire/cli/strategy/manual_commit_test.go Use require.NotNil for loaded state validation.
cmd/entire/cli/strategy/manual_commit_hooks.go Add gosec suppressions for writing commit message file passed by hook.
cmd/entire/cli/strategy/manual_commit_condensation_test.go Use require.NotNil for token usage results.
cmd/entire/cli/strategy/manual_commit_attribution_test.go Use require.NotNil for attribution result validation.
cmd/entire/cli/state_test.go Use require.NotNil for loaded state validation.
cmd/entire/cli/lifecycle_test.go Use require.NotNil for loaded state validation after compaction.
cmd/entire/cli/lifecycle.go Add gosec suppression for writing prompt.txt under session metadata dir.
cmd/entire/cli/hook_registry_test.go Use require.NotNil for subcommand lookup.
cmd/entire/cli/git_operations_test.go Use require.NotNil for author result validation.
cmd/entire/cli/explain_test.go Use require.NotNil for flag lookup.
cmd/entire/cli/checkpoint/checkpoint_test.go Use require.NotNil for committed summary validation.
cmd/entire/cli/agent/opencode/transcript_test.go Use require.NotNil for parsed session/usage validation.
cmd/entire/cli/agent/opencode/lifecycle_test.go Use require.NotNil for parsed event validation.
cmd/entire/cli/agent/geminicli/lifecycle_test.go Use require.NotNil for parsed event validation.
cmd/entire/cli/agent/factoryaidroid/lifecycle_test.go Use require.NotNil for parsed event validation.
cmd/entire/cli/agent/cursor/lifecycle_test.go Use require.NotNil for parsed event validation.
cmd/entire/cli/agent/copilotcli/lifecycle_test.go Use require.NotNil for parsed event validation.
cmd/entire/cli/agent/copilotcli/hooks_test.go Use require.NotNil for round-trip lookup validation.
cmd/entire/cli/agent/claudecode/lifecycle_test.go Use require.NotNil for parsed event/result validation.

You can also share your feedback on Copilot code review. Take the survey.

Soph added 2 commits March 16, 2026 12:22
Entire-Checkpoint: 2a7777ef04d0
Entire-Checkpoint: e4554445bb68
@Soph Soph marked this pull request as ready for review March 16, 2026 12:22
@Soph Soph requested a review from a team as a code owner March 16, 2026 12:22
@Soph Soph merged commit 061981a into main Mar 16, 2026
3 checks passed
@Soph Soph deleted the soph/go-1-26-1 branch March 16, 2026 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants