Skip to content

feat: add secure clear from code rabbit #628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gamalielhere merged 2 commits into from
Mar 26, 2025
Merged

feat: add secure clear from code rabbit #628

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8ced84b
feat: add secure clear from code rabbit
gamalielhere Mar 11, 2025
ec5b0b6
Merge branch 'devop/pakage-updates' of github.com:enkryptcom/enKrypt …
gamalielhere Mar 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions packages/extension/src/ui/onboard/create-wallet/wallet-ready.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,11 +44,21 @@ import { onMounted } from 'vue';
const onboardStore = useOnboardStore();
const restoreStore = useRestoreStore();

// Overwrite the string with random data before setting empty
const secureClear = (value: string) => {
const array = new Uint8Array(value.length);
crypto.getRandomValues(array);
const random = String.fromCharCode(...array);
value = random;
value = '';
return value;
};
Comment thread
olgakup marked this conversation as resolved.

onMounted(() => {
onboardStore.setPassword('');
onboardStore.setMnemonic('');
restoreStore.setMnemonic('');
restoreStore.setPassword('');
onboardStore.setPassword(secureClear(onboardStore.password));
onboardStore.setMnemonic(secureClear(onboardStore.mnemonic));
restoreStore.setMnemonic(secureClear(onboardStore.mnemonic));
restoreStore.setPassword(secureClear(onboardStore.password));
Comment thread
gamalielhere marked this conversation as resolved.
});

const finishAction = () => {
Expand Down