IteratorByteStream: split large iterator chunks into 64 KB pieces#3752
Open
Treadgold wants to merge 2 commits intoencode:masterfrom
Open
IteratorByteStream: split large iterator chunks into 64 KB pieces#3752Treadgold wants to merge 2 commits intoencode:masterfrom
Treadgold wants to merge 2 commits intoencode:masterfrom
Conversation
Author
|
Just realized there’s an existing PR (#3661) for this — completely happy for this one to be closed if maintainers prefer theirs, I should have checked before starting. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Split large iterator chunks in
IteratorByteStreaminto 64KB pieces to prevent memory spikes when sending large content streams.This ensures that very large generator chunks are safely split into manageable sizes internally without changing the public API.
A test was added in
tests/test_content.pyto verify that large chunks are split correctly.Checklist
Closes #3660