Add "trailing_headers" extension for HTTP/1.1#582
Closed
lovelydinosaur wants to merge 8 commits intomasterfrom
Closed
Add "trailing_headers" extension for HTTP/1.1#582lovelydinosaur wants to merge 8 commits intomasterfrom
lovelydinosaur wants to merge 8 commits intomasterfrom
Conversation
Kludex
reviewed
Sep 29, 2022
Contributor
Kludex
left a comment
Kludex
left a comment
There was a problem hiding this comment.
There's no mention about the TE headers. Is it intended? 🤔
Co-authored-by: Marcelo Trylesinski <[email protected]>
Contributor
Author
|
Ah gotcha... I see that now yes. The presence of a
But yes, it makes sense to include it in the example. It'd be really nice to have a real URL we can point at for this one. 🤣 |
…encode/httpcore into http11-trailing-headers-support
Contributor
Author
|
Right. Needs a |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See encode/httpx#1149
Adding support in HTTP/2 should be similar, requiring the
h2.TrailersReceivedevent to populate any trailing headers.https://python-hyper.org/projects/h2/en/stable/api.html#h2.events.TrailersReceived