Skip to content

Revert "Use AnyIO with fast_acquire synchronization "#1002

Merged
lovelydinosaur merged 1 commit intomasterfrom
revert-953-anyio-fast-acquire
Mar 31, 2025
Merged

Revert "Use AnyIO with fast_acquire synchronization "#1002
lovelydinosaur merged 1 commit intomasterfrom
revert-953-anyio-fast-acquire

Conversation

@lovelydinosaur
Copy link
Contributor

@lovelydinosaur lovelydinosaur commented Mar 27, 2025

Reverts #953

@graingert graingert self-requested a review March 27, 2025 18:09
@lovelydinosaur lovelydinosaur mentioned this pull request Mar 27, 2025
Merged
3 tasks
@MarkusSintonen
Copy link
Contributor

MarkusSintonen commented Mar 28, 2025

Why?

@lovelydinosaur lovelydinosaur merged commit 38f277c into master Mar 31, 2025
5 checks passed
@lovelydinosaur lovelydinosaur deleted the revert-953-anyio-fast-acquire branch March 31, 2025 10:30
@lovelydinosaur
Copy link
Contributor Author

lovelydinosaur commented Mar 31, 2025

I was surprised by the merge-without-review on that pull request.

There's smarter simpler approaches to connection pooling: tho it'll need a more careful engineering approach.
For the meantime I'd expect httpcore and httpx changes to focus on a new release resolving the breaking behaviour change identified in #995

@methane
Copy link

methane commented Sep 29, 2025

There's smarter simpler approaches to connection pooling: tho it'll need a more careful engineering approach.

How much time would it take to implement that smarter approach? The performance issues with httpx are significant and affecting its popularity. openai/openai-python#1596

@MarkusSintonen
Copy link
Contributor

MarkusSintonen commented Sep 29, 2025 •
edited
Loading

How much time would it take to implement that smarter approach? The performance issues with httpx are significant and affecting its popularity. openai/openai-python#1596

Httpx/httpcore projects are pretty much dead. Better to just get rid of them. Fixes are not coming (any time in near future)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@graingert graingert graingert approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lovelydinosaur @MarkusSintonen @methane @graingert