Skip to content

WRN-19252: Fix VerboseLogPlugin is not working #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hong6316 merged 2 commits into from
Mar 31, 2022
Merged

WRN-19252: Fix VerboseLogPlugin is not working #91

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5b43d31
WRN-19252: Use ProgressPlugin from originated place
MikyungKim Mar 29, 2022
0a22fac
pinned webpack version
MikyungKim Mar 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion mixins/verbose.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,14 @@ const helper = require('../config-helper');
const VerboseLogPlugin = require('../plugins/VerboseLogPlugin');

module.exports = {
apply: function (config) {
apply: function (config, opts = {}) {
const prerenderInstance = helper.getPluginByName(config, 'PrerenderPlugin');
const snapshotPluginInstance = helper.getPluginByName(config, 'SnapshotPlugin');

return config.plugins.push(
new VerboseLogPlugin({
prerenderPlugin: prerenderInstance && prerenderInstance.constructor,
ProgressPlugin: opts.ProgressPlugin,
snapshotPlugin: snapshotPluginInstance && snapshotPluginInstance.constructor
})
);
Expand Down
84 changes: 42 additions & 42 deletions npm-shrinkwrap.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,6 @@
"html-webpack-plugin": "^5.3.2",
"prettier": "^2.6.0",
"react": "^17.0.2",
"webpack": "^5.64.4"
"webpack": "5.64.4"
}
}
2 changes: 1 addition & 1 deletion plugins/VerboseLogPlugin/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@

const path = require('path');
const {Instance: Chalk} = require('chalk');
const {ProgressPlugin} = require('webpack');

class VerboseLogPlugin {
constructor(options = {}) {
Expand All @@ -12,6 +11,7 @@ class VerboseLogPlugin {

apply(compiler) {
const opts = this.options;
const {ProgressPlugin} = opts;
const columns = this.options.stream.isTTY && this.options.stream.columns;
const chalk = new Chalk({enabled: !!this.options.stream.isTTY});
let active;
Expand Down