Skip to content

Raise ENOSYS if AT_SYMLINK_NOFOLLOW is used with chmod or chown in nodefs#23307

Merged
hoodmane merged 3 commits into
emscripten-core:mainfrom
hoodmane:symlink-no-follow
Jan 9, 2025
Merged

Raise ENOSYS if AT_SYMLINK_NOFOLLOW is used with chmod or chown in nodefs#23307
hoodmane merged 3 commits into
emscripten-core:mainfrom
hoodmane:symlink-no-follow

Conversation

@hoodmane

@hoodmane hoodmane commented Jan 6, 2025

Copy link
Copy Markdown
Collaborator

It cannot support this since node doesn't support it. So we should tell the truth that we can't do it instead of ignoring it.

@hoodmane

hoodmane commented Jan 9, 2025

Copy link
Copy Markdown
Collaborator Author

I realized this has no interaction with #23058 so I moved it off of that and now the diff here is quite small @sbc100.

@hoodmane hoodmane merged commit 675698d into emscripten-core:main Jan 9, 2025
@hoodmane hoodmane deleted the symlink-no-follow branch January 9, 2025 19:40
@sbc100

sbc100 commented Jan 9, 2025

Copy link
Copy Markdown
Collaborator

Looks like this was missing the code size updates. I'll land an update now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants