Add normalize_bitstring_modifiers option to formatter#11840
Merged
whatyouhide merged 4 commits intoelixir-lang:mainfrom May 17, 2022
Merged
Add normalize_bitstring_modifiers option to formatter#11840whatyouhide merged 4 commits intoelixir-lang:mainfrom
normalize_bitstring_modifiers option to formatter#11840whatyouhide merged 4 commits intoelixir-lang:mainfrom
Conversation
sabiwara
force-pushed
the
11811-formatter-bitstring-mod
branch
from
49d553d to
8352153
Compare
whatyouhide
reviewed
May 16, 2022
Member
whatyouhide
left a comment
whatyouhide
left a comment
There was a problem hiding this comment.
This looks fantastic! Left just a couple of comments.
| state = %{normalize_bitstring_modifiers: true} | ||
| ) | ||
| when is_atom(atom) and empty_args in [nil, []] do | ||
| empty_args = bitstring_spec_notmalized_empty_args(atom) |
Member
There was a problem hiding this comment.
Typo in this function name 🙃
Suggested change
| empty_args = bitstring_spec_notmalized_empty_args(atom) | |
| empty_args = bitstring_spec_normalized_empty_args(atom) |
Needs to be updated below too.
Contributor
Author
There was a problem hiding this comment.
Woops, thank you 😅 Fixed
josevalim
reviewed
May 16, 2022
josevalim
approved these changes
May 16, 2022
Member
josevalim
left a comment
josevalim
left a comment
There was a problem hiding this comment.
Beautiful work, just some minor comments. :)
Co-authored-by: Andrea Leopardi <an.leopardi@gmail.com>
Co-authored-by: José Valim <jose.valim@gmail.com>
Contributor
Author
|
@whatyouhide @josevalim thank you for the reviews! |
whatyouhide
approved these changes
May 17, 2022
Member
|
Thanks @sabiwara! 💟 |
3 tasks
Member
@sabiwara go ahead, I don't think anyone has picked it up yet 🙃 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
This PR adds a
normalize_bitstring_modifiersboolean option as specified as #11811. Hope it helps.I'm happy to keep working on this issue and add
enforce_calls_on_right_hand_side_ofin an upcoming PR if nobody is working on this.