Skip to content

Meson: use modern features and fix deprecations#285

Merged
danirabbit merged 5 commits into
masterfrom
danirabbit/modern-meson
Aug 18, 2023
Merged

Meson: use modern features and fix deprecations#285
danirabbit merged 5 commits into
masterfrom
danirabbit/modern-meson

Conversation

@danirabbit
Copy link
Copy Markdown
Member

@danirabbit danirabbit commented Aug 11, 2023

Can't use install_symlink yet because of a bug in our version of Meson

@danirabbit danirabbit changed the title Meson: Replace custom scripts with built-in functions Meson: use modern features and fix deprecations Aug 11, 2023
@danirabbit danirabbit marked this pull request as ready for review August 11, 2023 17:04
@danirabbit danirabbit requested a review from a team August 11, 2023 17:04
@ryonakano
Copy link
Copy Markdown
Member

Maybe we can replace the following join_paths too?

ryo@lb450m:~/work/tmp/default-settings (danirabbit/modern-meson =)$ git grep -n join_paths
meson.build:9:datadir = join_paths(prefix, get_option('datadir'))
meson.build:11:schemadir = join_paths(datadir, 'glib-2.0', 'schemas')
meson.build:15:symlink = join_paths(meson.current_source_dir (), 'meson', 'create-symlink.sh')
meson.build:20:    install_dir: join_paths(sysconfdir, 'profile.d'),
meson.build:27:    install_dir: join_paths(sysconfdir, 'sudoers.d')
meson.build:33:    install_dir: join_paths(datadir, 'cups', 'data')
meson.build:39:    install_dir: join_paths(sysconfdir, 'gtk-3.0')
meson.build:45:    install_dir: join_paths(datadir, 'applications')
overrides/meson.build:13:        install_dir: join_paths(schemadir)
overrides/meson.build:21:        install_dir: join_paths(schemadir)
skel/meson.build:1:skeldir = join_paths(sysconfdir, 'skel')
skel/meson.build:7:        install_dir: join_paths(skeldir, '.config')
skel/meson.build:15:        install_dir: join_paths(skeldir, '.local', 'share')
ryo@lb450m:~/work/tmp/default-settings (danirabbit/modern-meson =)$ 

@danirabbit danirabbit requested a review from ryonakano August 18, 2023 17:59
Copy link
Copy Markdown
Member

@ryonakano ryonakano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good and ninja install works too.

@danirabbit danirabbit merged commit 59c8aba into master Aug 18, 2023
@danirabbit danirabbit deleted the danirabbit/modern-meson branch August 18, 2023 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants