Add linux/arm64 to the docker build platforms. - #140
Open
pixlwave wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There isn't an OCI container image published for ARM64, so this PR adds the platform to the docker workflow to make testing easier on macOS.
I've tested that it builds for
arm64withcontainer build --platform linux/arm64 --file docker/Dockerfile --tag matrix-content-scanner:arm64 . container image inspect matrix-content-scanner:arm64which was successful and indicates the correct platform
I can spin up a container from the image which starts and is reachable (but I haven't tried to scan any media).
Full disclosure: The changes were made with the suggestions from an LLM and they look correct to me from my research, but my personal experience in this area is basically limited to running
container build xyzlocally.