Add test data#8
Merged
elboyran merged 6 commits intoleafsnap30-modelfrom Jan 17, 2023
Merged
Conversation
Collaborator
Author
|
I've updated the .json file manually by copying from the MNIST entry and updating the values. Ready for review now. To review the values in the json file: the shasum and bytes fields must match those given by github lfs for those files. |
elboyran
approved these changes
Jan 17, 2023
Owner
elboyran
left a comment
There was a problem hiding this comment.
Looks good. Will submit to ONNX and see what happens.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've removed the test data instructions from the README and added a .tar.gz file containing both the model and test data. The test data can be verified by running
python workflow_scripts/test_models.py --target onnxruntimein the root of the repo. It should output something like this:There is one more step that I can't get to work, perhaps someone else can help out here. The instructions are the following:
If this PR does update/add .onnx or .tar.gz files, please use python workflow_scripts/generate_onnx_hub_manifest.py --target diff to update ONNX_HUB_MANIFEST.json with according model information (especially SHA) for ONNX Hub.
However, when I run the script the json file is not updated. The script doest detected the leafsnap model though.