-
Notifications
You must be signed in to change notification settings - Fork 45
Update changelog docs for CDN TTL details #3679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
77b8532
6de16ad
b815a7e
0ed0cd2
4f9d002
263230f
647aab0
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,11 +5,16 @@ These files are ultimately used to generate release documentation. | |
|
|
||
| This page describes how to create these files both from the [command line](#command-line) and from [GitHub actions](#github-actions). | ||
|
|
||
| ## Before you begin | ||
| ## Before you begin [prerequisites] | ||
|
|
||
| Create a changelog configuration file to define all the default behavior and PR label mappings. | ||
| Refer to [](/contribute/configure-changelogs.md). | ||
|
|
||
| Choose whether you want to store the changelogs only in the public CDN or in both your GitHub repository and the CDN: | ||
|
|
||
| - If you have a large volume of notable changes every release, you will likely choose to store them *only* in the public CDN. | ||
| - If you have a small volume of changes or the content churns a lot before and after releases, you will likely choose to store them in *both* the repo and the public CDN. | ||
|
|
||
| ## Create changelog files from command line [command-line] | ||
|
|
||
| These steps describe how to use the [changelog add](/cli/changelog/add.md) command. | ||
|
|
@@ -93,6 +98,25 @@ Some of the fields in the schema accept only a specific set of values: | |
| You can further limit the possible values with the [products](/contribute/configure-changelogs-ref.md#products) and [lifecycles](/contribute/configure-changelogs-ref.md#lifecycles) options in the changelog configuration file. | ||
| ::: | ||
|
|
||
| ## Upload changelog files [upload] | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We shouldn't document folks manually uploading changelogs on the command line. Everything should be automated through our github actions and the timing of publishing these should not be arbitrary.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think the need for that will persist for the ad hoc releases and things like known issues, security issues, feature announcements, etc that aren't ncessary tied to a PR or release. AFAIK those aren't uploaded automatically yet. |
||
|
|
||
| After you're satisfied with the content of your changelog files, the last step is to upload them to the public CDN. | ||
|
|
||
| :::{important} | ||
| All changelog files should be uploaded to the public CDN, irrespective of whether you also want to maintain a copy in your GitHub repo. | ||
| ::: | ||
|
|
||
| - If you create changelog files from the command line, use the [changelog upload](/cli/changelog/upload.md) command to upload them. | ||
| - If you create your changelogs from GitHub actions, add an upload workflow. Refer to [Uploading to S3](https://github.com/elastic/docs-actions/blob/main/changelog/README.md#uploading-to-s3) and [changelog-upload.yml](https://github.com/elastic/docs-actions/blob/main/.github/workflows/changelog-upload.yml). | ||
|
|
||
| Files land in a private bucket, which is the internal source of truth. | ||
| A scrubber Lambda automatically mirrors sanitized copies (with private repository references removed) to the public bucket. | ||
| Changelog entries are uploaded into `changelog/{org}/{repo}/{branch}/{filename}`. | ||
|
|
||
| :::{note} | ||
| It can take between 60 seconds to an hour before updates appear in the public CDN. | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is a bug, lets zoom in |
||
| ::: | ||
|
|
||
| ## Examples | ||
|
|
||
| ### Control changelog creation [rules] | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this an hour @cotti ?