fix: stop workflow-run pagination at --since boundary before conclusion filter#1248
Merged
Merged
Conversation
Stop pagination as soon as workflow runs cross the --since boundary, even when the run does not match --conclusion. Add a regression test covering the since+conclusion boundary case. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
v1v
approved these changes
Jun 15, 2026
github-actions
Bot
added
the
small_boom
This was referenced Jun 22, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--since, before applying conclusion filtering--conclusionand--until--since+--conclusioninteraction where the boundary run does not match conclusionWhy
list_workflow_runspreviously applied conclusion filtering before checking the--sinceboundary. If the first run older than--sincehad a non-matching conclusion, the function skipped that run and continued to the next page unnecessarily.Testing
make test(fails in this environment becauseuvis unavailable)/tmp/gh-aw/agent/venv/bin/python -m pytest tests/test_fetch_workflow_logs.py -q/tmp/gh-aw/agent/venv/bin/python -m pytest tests/ -qCloses #1247
What is this? | From workflow: Trigger Bug Hunter
Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not.