fix: handle timezone-aware --until filtering in fetch-workflow-logs#1237
Draft
github-actions[bot] wants to merge 2 commits into
Draft
fix: handle timezone-aware --until filtering in fetch-workflow-logs#1237github-actions[bot] wants to merge 2 commits into
github-actions[bot] wants to merge 2 commits into
Conversation
Compare workflow run timestamps as parsed UTC datetimes instead of lexicographic strings so timezone offsets are handled correctly. Add regression test for an --until value with +01:00 offset. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Treat empty timestamp strings as missing values to avoid crashing boundary checks, and add regression coverage. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes incorrect workflow run filtering when
scripts/fetch-workflow-logs.pyis called with a timezone-aware--untilvalue (for example2025-01-01T00:00:00+01:00).The previous implementation compared
created_atand boundary values as raw strings, which can misorder valid ISO-8601 timestamps with different timezone forms (Zvs+HH:MM).Changes
--untilbehavior inclusive by preserving end-of-day normalization.--untilcutoff behaviorcreated_athandling with an--untilfilterValidation
python -m pytest tests/test_fetch_workflow_logs.py -vpython -m pytest tests/ -qCloses #1236.
What is this? | From workflow: Trigger Bug Hunter
Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not.