Helper class and small change for where a2 / b2 is none or not specified#2
Open
Hecatron wants to merge 1 commit into
Open
Helper class and small change for where a2 / b2 is none or not specified#2Hecatron wants to merge 1 commit into
Hecatron wants to merge 1 commit into
Conversation
…asier, also made a small change to patchit.py for when the a2 / b2 values are not specified in a diff which can sometimes show up with diff -Naur
Owner
|
Hey! Thanks for contributing. The Python3 compatibility is actually a little bit lacking. There is a little confusing with the encoding and Unicode for file content and unified diff files. I rewrote these parts of the library some time ago with clear Python2 and Python3 compatibility in mind but unfortunately got stuck and distracted midway. I'll look into it and try to get it done and rebase your work on top of it next weekend since there seems to be some interest in this library. Please stay patient and thanks for your interest in this library! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I've been using the patchit module because it seems to be one of the few python ones compatible with python 3
I've added a small helper class to make patching files easier
also I noticed when running diff -Naur against a couple of directories sometimes a2 / b2 is not specified so should be assumed to be 0 instead of None
as an example
diff -Naur original\sox/libgsm/CMakeLists.txt packages\sox/libgsm/CMakeLists.txt
--- original\sox/libgsm/CMakeLists.txt Wed Mar 2 22:10:27 2011
+++ packages\sox/libgsm/CMakeLists.txt Thu Aug 20 10:59:03 2015
@@ -1 +1,9 @@
add_library(gsm add code decode gsm_create gsm_decode gsm_destroy gsm_encode gsm_option long_term lpc preprocess rpe short_term table)
+
+# Set the Output Directory for libs
+set_target_properties( gsm
+)