Skip to content

Remove lookahead pattern syntax and forced rule lookaheads#65

Merged
ehwan merged 1 commit into
breaking_changefrom
remove_lookahead_syntax
Jun 19, 2026
Merged

Remove lookahead pattern syntax and forced rule lookaheads#65
ehwan merged 1 commit into
breaking_changefrom
remove_lookahead_syntax

Conversation

@ehwan

@ehwan ehwan commented Jun 19, 2026

Copy link
Copy Markdown
Owner

Removes the P / term lookahead pattern syntax and the associated forced lookahead plumbing.

Changes

  • Removed PatternArgs::Lookaheads and PatternInternal::Lookaheads
  • Removed Pattern slash Pattern parsing support and regenerated the bootstrap parser
  • Removed rule-level forced lookaheads from rusty_lr_core builder logic
  • Removed the NonTerminalType::Lookahead marker
  • Updated syntax/docs references

@ehwan ehwan self-assigned this Jun 19, 2026
@ehwan
ehwan merged commit 4ece456 into breaking_change Jun 19, 2026
@ehwan
ehwan deleted the remove_lookahead_syntax branch June 19, 2026 14:43

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the lookahead assertion feature from the parser generator. This cleanup simplifies the grammar, parser, and pattern matching logic by removing lookahead-related fields, types, and parsing rules across multiple files, including rusty_lr_core, rusty_lr_parser, and associated documentation. I have no additional feedback to provide as the changes are clean and consistent.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant