remove unused %filter directives and update token matching documentation#61
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes the %filter directive and all its associated logic, errors, tests, and documentation from the parser. Instead of using a custom filter function, token classification now relies directly on native Rust pattern matching, which simplifies the codebase and documentation. I have no further feedback to provide as there are no review comments.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This Pull Request simplifies the grammar specification and the code generator by completely removing two unused and legacy syntax directives:
%traceand%filter.Key Changes
%filterDirective:%filterparsing rules, arguments, macro substitution, and verification logic.MultipleFilterDefinitionandFilterNotDefinedfromrusty_lr_parserandrusty_lr_buildscript.example/calculator).SYNTAX.md,README.md):%filter, and$filter.%tokendefinition section inSYNTAX.mdwith detailed instructions and examples on using native Rust structural pattern matching (destructuring) for wrapped/struct tokens.