Skip to content

remove unused %filter directives and update token matching documentation#61

Merged
ehwan merged 1 commit into
breaking_changefrom
remove_filter
Jun 19, 2026
Merged

remove unused %filter directives and update token matching documentation#61
ehwan merged 1 commit into
breaking_changefrom
remove_filter

Conversation

@ehwan

@ehwan ehwan commented Jun 19, 2026

Copy link
Copy Markdown
Owner

Description

This Pull Request simplifies the grammar specification and the code generator by completely removing two unused and legacy syntax directives: %trace and %filter.

Key Changes

  1. Removed %filter Directive:
    • Removed %filter parsing rules, arguments, macro substitution, and verification logic.
    • Deleted the unused diagnostic errors MultipleFilterDefinition and FilterNotDefined from rusty_lr_parser and rusty_lr_buildscript.
    • Removed the filter function implementation and directive from the calculator example (example/calculator).
  2. Documentation Updates (SYNTAX.md, README.md):
    • Removed all references to %filter, and $filter.
    • Enhanced the %token definition section in SYNTAX.md with detailed instructions and examples on using native Rust structural pattern matching (destructuring) for wrapped/struct tokens.

@ehwan ehwan self-assigned this Jun 19, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the %filter directive and all its associated logic, errors, tests, and documentation from the parser. Instead of using a custom filter function, token classification now relies directly on native Rust pattern matching, which simplifies the codebase and documentation. I have no further feedback to provide as there are no review comments.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@ehwan
ehwan merged commit 8220958 into breaking_change Jun 19, 2026
@ehwan
ehwan deleted the remove_filter branch June 19, 2026 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant